daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 )
Change subject: common: trx_if.adoc: Improve documentation ...................................................................... Patch Set 6: Code-Review+2 (2 comments) https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc File common/chapters/trx_if.adoc: https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc@163 PS5, Line 163: 64-95: ...Payload... > Here it's 32 bits, enough to fill one entire row to showcase where data goes, > because 187*8 or 444*8 […] Ah, sorry. With regards to the diagram this creates it makes sense! https://gerrit.osmocom.org/#/c/14938/5/common/chapters/trx_if.adoc@209 PS5, Line 209: 48-95: ...Payload... > That's 48 bits, not bytes. Explained in the above comment. Done -- To view, visit https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/14938 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: master Gerrit-Change-Id: I36e6206b90435964842f9f1ebd982cdaf9777018 Gerrit-Change-Number: 14938 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Wed, 31 Jul 2019 13:10:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: daniel <[email protected]> Gerrit-MessageType: comment
