pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 )
Change subject: vty/telnet_interface.c: log connection accept() / close() events ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/14972/1/src/vty/telnet_interface.c File src/vty/telnet_interface.c: https://gerrit.osmocom.org/#/c/14972/1/src/vty/telnet_interface.c@131 PS1, Line 131: rc = getsockname(fd->fd, (struct sockaddr *) &sockaddr, &len); What about using osmo_sock_get_name_buf() here? https://gerrit.osmocom.org/#/c/14972/1/src/vty/telnet_interface.c@187 PS1, Line 187: inet_ntoa(sockaddr.sin_addr), ntohs(sockaddr.sin_port)); Let's use inet_ntop, which is thread-safe. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c Gerrit-Change-Number: 14972 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 29 Jul 2019 12:47:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
