pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14972 )
Change subject: vty/telnet_interface.c: log connection accept() / close() events ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/14972/2/src/vty/telnet_interface.c File src/vty/telnet_interface.c: https://gerrit.osmocom.org/#/c/14972/2/src/vty/telnet_interface.c@129 PS2, Line 129: osmo_sock_get_name_buf(sock_name_buf, OSMO_SOCK_NAME_MAXLEN, fd->fd); You must check for negative here, and in that case don't use sock_name_buf (it may be uninitialized). https://gerrit.osmocom.org/#/c/14972/2/src/vty/telnet_interface.c@182 PS2, Line 182: osmo_sock_get_name_buf(sock_name_buf, OSMO_SOCK_NAME_MAXLEN, new_connection); Same here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14972 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c Gerrit-Change-Number: 14972 Gerrit-PatchSet: 2 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2019 11:31:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
