daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14966 )
Change subject: Fix return variable of strtoul() ...................................................................... Patch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp-client/mgcp_client.c File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp-client/mgcp_client.c@312 PS1, Line 312: r->codecs[count] = pt; r->codecs[] is an enum which will probably only be int in size. As RTP pt is 7-bit anyway does it make sense to limit the range of pt to [0,127] here and goto response_parse_failure_pt in case it's outside? https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp/mgcp_sdp.c File src/libosmo-mgcp/mgcp_sdp.c: https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp/mgcp_sdp.c@168 PS1, Line 168: if (codecs[i].payload_type == pt) Here as well -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ice9eee6a252fab73dbab5ebf3cfc83c1b354fd08 Gerrit-Change-Number: 14966 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 29 Jul 2019 14:50:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
