daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14966 )
Change subject: Fix return variable of strtoul() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp-client/mgcp_client.c File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/#/c/14966/1/src/libosmo-mgcp-client/mgcp_client.c@312 PS1, Line 312: r->codecs[count] = pt; > How you provide feedback on where pt is specified being 7-bit and why? Lots of places only specify 0-127 as values (with the latter being dynamic). So I looked into the RTP spec and the field there is 7-bit wide. See https://tools.ietf.org/html/rfc3550#section-5 field PT. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/14966 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ice9eee6a252fab73dbab5ebf3cfc83c1b354fd08 Gerrit-Change-Number: 14966 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 29 Jul 2019 16:02:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: daniel <[email protected]> Gerrit-MessageType: comment
