Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14974 )
Change subject: vty/vty.c: log received commands from telnet interface ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14974/1/src/vty/vty.c File src/vty/vty.c: https://gerrit.osmocom.org/#/c/14974/1/src/vty/vty.c@441 PS1, Line 441: > What about moving the code in here and then you can probably drop the > vty->length>0 condition? Well, cmd_make_strvec() may fail due to various reasons, so I think it's better to do logging before this call. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5f6639f6ebc3e8f8df50ef48538df94285b759fd Gerrit-Change-Number: 14974 Gerrit-PatchSet: 1 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 30 Jul 2019 03:32:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
