neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14974 )
Change subject: vty/vty.c: log received commands from telnet interface ...................................................................... Patch Set 3: I think this is a good idea, but causes unit tests to get unexpected log output. Also it changes the application's user interaction behavior just by using a different libosmocore version, which we should avoid. I think you need to solve this by adding a flag that keeps VTY command logging disabled by default, so that all the unit tests that work with both VTY and log output remain unchanged and keep passing. This could either be a boolean flag that the main() scope of each application sets to true in C, and/or this could be set to true by an actual vty config item. An example for such a flag would be osmo_fsm_term_safely(), e.g. set to true in msc_main.c, but off by default to not cause inadvertent behavioral changes from a new libosmocore version. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14974 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I5f6639f6ebc3e8f8df50ef48538df94285b759fd Gerrit-Change-Number: 14974 Gerrit-PatchSet: 3 Gerrit-Owner: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Comment-Date: Tue, 30 Jul 2019 16:57:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
