pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 )
Change subject: Add support for MNCC HOLD/RETRIEVE ...................................................................... Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14996/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/14996/1/src/mncc.c@681 PS1, Line 681: other_leg->hold_call(other_leg); Just wondering... cannot hold_call fail? in that case I'm not sure if MNCC_HOLD_CNF should be sent back. https://gerrit.osmocom.org/#/c/14996/1/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14996/1/src/sip.c@291 PS1, Line 291: struct sip_call_leg *leg = sip_find_leg(nh); Wasn't this already added on a prior commit? -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ife7bdab20cde92b7ce550215bab28b36a0f302e9 Gerrit-Change-Number: 14996 Gerrit-PatchSet: 1 Gerrit-Owner: keith <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2019 15:11:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
