keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 )
Change subject: Add support for MNCC HOLD/RETRIEVE ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14996/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/14996/1/src/mncc.c@681 PS1, Line 681: other_leg->hold_call(other_leg); > Just wondering... […] I've been looking at it... Not sure in what case the other side would do anything other than ACK the reINVITE, other than a complete failure, in which case our call is failing anyway. But yes, we should probably not send HOLD_CNF back until the remote SIP has sent back an ACK. I would really like however, if we could move forward based on what is likely to happen in a real world setup, where the SIP EP operator is /expecting/ to talk to osmo-sip-connector (which is far from complete BTW) Otherwise, I might as well say, "oh look, it doesn't even handle a 100rel." -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14996 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ife7bdab20cde92b7ce550215bab28b36a0f302e9 Gerrit-Change-Number: 14996 Gerrit-PatchSet: 1 Gerrit-Owner: keith <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <ke...@rhizomatica.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 01 Aug 2019 12:34:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
