laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15209 )
Change subject: gsm_08_08.c: always pick first msc for unsolicit paging responses ...................................................................... Patch Set 1: (3 comments) https://gerrit.osmocom.org/#/c/15209/1/src/osmo-bsc/gsm_08_08.c File src/osmo-bsc/gsm_08_08.c: https://gerrit.osmocom.org/#/c/15209/1/src/osmo-bsc/gsm_08_08.c@328 PS1, Line 328: LOGP(DMSC, LOGL_ERROR, "Got paged but no subscriber found, will now (blindly) deliver the paging response to the first configured MSC!\n"); > s/Got paged/Got Paging Response ? ACK https://gerrit.osmocom.org/#/c/15209/1/src/osmo-bsc/gsm_08_08.c@349 PS1, Line 349: LOGL_ERROR this is not an error condition, but a perfectly normal situation in the context of CSFB. It should be INFO, maximum. https://gerrit.osmocom.org/#/c/15209/1/src/osmo-bsc/gsm_08_08.c@358 PS1, Line 358: * blindly. */ > This entire code looks like weird legacy bsc-nat stuff, I've never used > osmo-bsc with more than one […] the code is unrelated to bsc-nat. OsmoBSC once was extended to talk to multiple MSC so you can have a "remote" normal BSC and a local one in case your backhaul fails, or in case you want to route some subscribers locally onboard a vessel. That use case has disappeared now, we could remove it. But we must not change the VTY syntax while doing it. In any case that's unrelated to the current patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15209 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I7f091ed1bbc2afe12656e42031e122144eeb6826 Gerrit-Change-Number: 15209 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-CC: laforge <lafo...@gnumonks.org> Gerrit-CC: neels <nhofm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 15 Aug 2019 15:55:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Gerrit-MessageType: comment
