laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15265 )
Change subject: fix: vty crash by logging to killed telnet session ...................................................................... Patch Set 2: I'm actually with Pau on this one, and I would have independently "complained" about it in the review, if he hadn't brought it up. At the very least the root cause should be fixed, and then as a second, less important item we can discuss whether or not we should emply 'defensive programming' by checking for null here. I would actually rather OSMO_ASSERT on NULL situations, rather than silently dropping it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idca3f54dc986abf6784790c12e69e02bdf77cb41 Gerrit-Change-Number: 15265 Gerrit-PatchSet: 2 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Thu, 29 Aug 2019 05:46:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
