fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15265 )
Change subject: sanity: make vty buffer_* API NULL safe ...................................................................... Patch Set 3: Code-Review+1 (4 comments) https://gerrit.osmocom.org/#/c/15265/3/src/vty/buffer.c File src/vty/buffer.c: https://gerrit.osmocom.org/#/c/15265/3/src/vty/buffer.c@204 PS3, Line 204: if (!b) Cosmetic: we already have similar check in buffer_put(). https://gerrit.osmocom.org/#/c/15265/3/src/vty/buffer.c@212 PS3, Line 212: if (!b) Cosmetic: we already have similar check in buffer_put(). https://gerrit.osmocom.org/#/c/15265/3/src/vty/buffer.c@225 PS3, Line 225: !b Probably BUFFER_ERROR is better in this case. https://gerrit.osmocom.org/#/c/15265/3/src/vty/buffer.c@419 PS3, Line 419: BUFFER_EMPTY Why not BUFFER_ERROR? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15265 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Idca3f54dc986abf6784790c12e69e02bdf77cb41 Gerrit-Change-Number: 15265 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Thu, 29 Aug 2019 23:54:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
