pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15373 )
Change subject: Cell Broadcast: CBSP and CBCH scheduling support ...................................................................... Patch Set 2: (5 comments) https://gerrit.osmocom.org/#/c/15373/2/doc/manuals/chapters/smscb.adoc File doc/manuals/chapters/smscb.adoc: https://gerrit.osmocom.org/#/c/15373/2/doc/manuals/chapters/smscb.adoc@43 PS2, Line 43: configuration more simple, ti also can operate in TCP client mode, typo: ti->it. https://gerrit.osmocom.org/#/c/15373/2/doc/manuals/chapters/smscb.adoc@44 PS2, Line 44: connecting to the CBC. This way the BSCs all need to know the CBC IP 1- Extra space after dot. 2- "This way the BSCs all need to know IS the CBC IP address". https://gerrit.osmocom.org/#/c/15373/2/doc/manuals/chapters/smscb.adoc@45 PS2, Line 45: address, but not vice-versa Missing dot. https://gerrit.osmocom.org/#/c/15373/2/src/osmo-bsc/smscb.c File src/osmo-bsc/smscb.c: https://gerrit.osmocom.org/#/c/15373/2/src/osmo-bsc/smscb.c@44 PS2, Line 44: /* replace the old head of an entire list with e new head; effectively moves the entire "a new head" https://gerrit.osmocom.org/#/c/15373/2/src/osmo-bsc/smscb.c@142 PS2, Line 142: static struct osmo_cell_global_id cgi; What about passing it as a parameter and filling it from there? This way space is not lost for users who don't plan to use CBCH. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia0a0de862a104d0f447a5d6e56c7c83981b825c7 Gerrit-Change-Number: 15373 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 02 Sep 2019 09:41:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
