laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/15373 )
Change subject: Cell Broadcast: CBSP and CBCH scheduling support ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15373/2/src/osmo-bsc/smscb.c File src/osmo-bsc/smscb.c: https://gerrit.osmocom.org/#/c/15373/2/src/osmo-bsc/smscb.c@142 PS2, Line 142: static struct osmo_cell_global_id cgi; > What about passing it as a parameter and filling it from there? This way > space is not lost for users […] are we arguing about something like 16 estimated bytes for the entire program? For sure I'm against bloat, but we're not talking about anything worth considerng here. Ease of development is more important thant those few bytes, for sure. -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/15373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia0a0de862a104d0f447a5d6e56c7c83981b825c7 Gerrit-Change-Number: 15373 Gerrit-PatchSet: 2 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Mon, 02 Sep 2019 09:59:44 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
