fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15361 )
Change subject: Move out gbproxy to its own subdir ...................................................................... Patch Set 2: (1 comment) It looks strange that you're introducing a static library, but in the end nobody will link against it o_O. Maybe I am missing something... https://gerrit.osmocom.org/#/c/15361/2/src/gbproxy/Makefile.am File src/gbproxy/Makefile.am: https://gerrit.osmocom.org/#/c/15361/2/src/gbproxy/Makefile.am@35 PS2, Line 35: $(top_builddir)/src/gprs/gprs_gb_parse.o \ : $(top_builddir)/src/gprs/gprs_llc_parse.o \ : $(top_builddir)/src/gprs/crc24.o \ : $(top_builddir)/src/gprs/gprs_utils.o \ Can we just link against 'libcommon.la' here? If no, please describe why in the comment message. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2cc98d3a276d953609bbbbaa9782a0112687791e Gerrit-Change-Number: 15361 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 02 Sep 2019 12:07:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
