pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/15361 )
Change subject: Move out gbproxy to its own subdir ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15361/2/src/gbproxy/Makefile.am File src/gbproxy/Makefile.am: https://gerrit.osmocom.org/#/c/15361/2/src/gbproxy/Makefile.am@35 PS2, Line 35: $(top_builddir)/src/gprs/gprs_gb_parse.o \ : $(top_builddir)/src/gprs/gprs_llc_parse.o \ : $(top_builddir)/src/gprs/crc24.o \ : $(top_builddir)/src/gprs/gprs_utils.o \ > Can we just link against 'libcommon.la' here? If no, please describe why in > the comment message. Indeed, I'm introducing a licommon.la which in the end is not used, in order to have all .o files built on one target (to avoid several targets building same files coming from different subdirs, and issues associated to that). I'm open to other alternatives that you think can be better, but this one is good enough. I could indeed link against libcommon.la here, but I prefer keeping it this way in order to keep information on exactly which files each application requires. Specially since some files may be splitted later since only 1 application is using a subset of it for instance, so we can shrink this common section without duplicating code. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/15361 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2cc98d3a276d953609bbbbaa9782a0112687791e Gerrit-Change-Number: 15361 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 02 Sep 2019 12:12:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
