fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/15539 )
Change subject: log: set L1 SAPI log context ...................................................................... Patch Set 7: (3 comments) https://gerrit.osmocom.org/#/c/15539/7/src/common/l1sap.c File src/common/l1sap.c: https://gerrit.osmocom.org/#/c/15539/7/src/common/l1sap.c@319 PS7, Line 319: L1SAP_COMMON_SAPI_PDTCH We may want to check if L1SAP_IS_PTCCH(u32Fn) here, and assign L1SAP_COMMON_SAPI_PTCCH. https://gerrit.osmocom.org/#/c/15539/7/src/common/l1sap.c@333 PS7, Line 333: L1SAP_IS_PTCCH There can be no DATA.ind on PTCCH, only DATA.req (comes from the PCU). https://gerrit.osmocom.org/#/c/15539/7/src/common/l1sap.c@338 PS7, Line 338: L1SAP_COMMON_SAPI_RACH Access Bursts can be also sent on PDTCH/U and PTCCH/U. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15539 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6b7bb2e1d61502b61214f854a4ec5cbb7267545b Gerrit-Change-Number: 15539 Gerrit-PatchSet: 7 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: fixeria <axilira...@gmail.com> Gerrit-Comment-Date: Wed, 09 Oct 2019 18:26:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
