fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/15539 )

Change subject: log: set L1 SAPI log context
......................................................................


Patch Set 8: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/15539/8/src/common/l1sap.c
File src/common/l1sap.c:

https://gerrit.osmocom.org/#/c/15539/8/src/common/l1sap.c@332
PS8, Line 332: L1SAP_COMMON_SAPI_PACCH
Use PDTCH here, because we don't know if it's PACCH or not.


https://gerrit.osmocom.org/#/c/15539/8/src/common/l1sap.c@338
PS8, Line 338: return L1SAP_COMMON_SAPI_UNKNOWN;
Unreacheable.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/15539
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: I6b7bb2e1d61502b61214f854a4ec5cbb7267545b
Gerrit-Change-Number: 15539
Gerrit-PatchSet: 8
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: fixeria <axilira...@gmail.com>
Gerrit-Comment-Date: Thu, 10 Oct 2019 15:32:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to