neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/15321 )
Change subject: gsup: Introduce OSMO_GSUP_NUM_VECTORS_REQ_IE ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/15321/4//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/15321/4//COMMIT_MSG@9 PS4, Line 9: This is a bit of a hack, as we want to maintain binary compatibility maintain binary compatibility: you mean as in the struct osmo_gsup_message size? We did add more elements to the struct on various occasions before this. Is this case different? We should maybe add a "more" bool indicator to the end to allow future extensions, like http://git.osmocom.org/libosmocore/tree/include/osmocom/gsm/gsm0808.h#n143 ? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/15321 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Iaecc47280f8ce54f3e3a888c1cfc160735483d0f Gerrit-Change-Number: 15321 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: neels <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 26 Nov 2019 03:23:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
