neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14864 )
Change subject: core/defs.h: introduce and use OSMO_DEPRECATED_OUTSIDE ...................................................................... Patch Set 3: (2 comments) This change is ready for review. https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/core/defs.h File include/osmocom/core/defs.h: https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/core/defs.h@46 PS3, Line 46: # define OSMO_DEPRECATED_OUTSIDE(text) > It's more clear if you keep and extend older name: […] since this macro is by definition only used within libosmocore, we don't need to keep the older variant around. We can simply replace all occurences of it and use the new text version everywhere. https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/gsm/gsm48_ie.h File include/osmocom/gsm/gsm48_ie.h: https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/gsm/gsm48_ie.h@18 PS3, Line 18: OSMO_DEPRECATED_OUTSIDE("Use gsm48_decode_bcd_number2() for improved bounds checking"); > Why shouldn't libosmocore use gsm48_decode_bcd_number2? […] probably for unit tests. It should still be deprecated in libosmocore, just not in unit tests, right? I think I've used switch-off-deprecation pragmas before somewhere for that purpose... a drawback might be that those aren't compiler portable, IIUC. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14864 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1b0eff1396776900c1286e41da3aee3ff78b326e Gerrit-Change-Number: 14864 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Comment-Date: Sat, 30 Nov 2019 02:23:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
