fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14864 )
Change subject: core/defs.h: introduce and use OSMO_DEPRECATED_OUTSIDE ...................................................................... Patch Set 3: (1 comment) This change is ready for review. https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/core/defs.h File include/osmocom/core/defs.h: https://gerrit.osmocom.org/c/libosmocore/+/14864/3/include/osmocom/core/defs.h@46 PS3, Line 46: # define OSMO_DEPRECATED_OUTSIDE(text) > We can simply replace all occurences of it and use the new text version > everywhere. ACK. "For internal use inside libosmocore only" does not give much details to the API users, e.g. what should they use instead. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/14864 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1b0eff1396776900c1286e41da3aee3ff78b326e Gerrit-Change-Number: 14864 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Comment-Date: Wed, 11 Dec 2019 05:27:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: neels <[email protected]> Gerrit-MessageType: comment
