laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16256 )
Change subject: add mDNS lookup method to libosmo-mslookup ...................................................................... Patch Set 7: (3 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/include/osmocom/mslookup/mdns.h File include/osmocom/mslookup/mdns.h: https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/include/osmocom/mslookup/mdns.h@15 PS7, Line 15: * You should have received a copy of the GNU Affero General Public License See my license comment on the other patch https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/src/mslookup/mdns.c File src/mslookup/mdns.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/src/mslookup/mdns.c@117 PS7, Line 117: case OSMO_MDNS_RFC_RECORD_TYPE_A: Typically no indent of case in switch, but not critical https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/src/mslookup/mdns_msg.c File src/mslookup/mdns_msg.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16256/7/src/mslookup/mdns_msg.c@67 PS7, Line 67: ret = talloc(ctx, struct osmo_mdns_msg_request); We rarely ose talloc without _zero as a safeguard. What if somebody adds some fields in the future ? -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I03a0ffa1d4dc1b24ac78a5ad0975bca90a49c728 Gerrit-Change-Number: 16256 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Sat, 30 Nov 2019 09:51:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
