keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16256 )
Change subject: add mDNS lookup method to libosmo-mslookup ...................................................................... Patch Set 11: (1 comment) https://gerrit.osmocom.org/c/osmo-hlr/+/16256/11/src/mslookup/mdns_sock.c File src/mslookup/mdns_sock.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16256/11/src/mslookup/mdns_sock.c@129 PS11, Line 129: int osmo_mdns_sock_send(const struct osmo_mdns_sock *mdns_sock, struct msgb *msg) I think it might be an idea to optionally put this on the wire more than once, based on a configuration option, or per request flag. I'm not sure if this is the place, or what the best practice is for such a thing. with for example. delay between sending -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16256 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I03a0ffa1d4dc1b24ac78a5ad0975bca90a49c728 Gerrit-Change-Number: 16256 Gerrit-PatchSet: 11 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: keith <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2020 11:44:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
