fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623 )
Change subject: pcu: add TC_paging_cs_from_bts ...................................................................... Patch Set 5: (4 comments) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623/5/library/RLCMAC_Types.ttcn File library/RLCMAC_Types.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623/5/library/RLCMAC_Types.ttcn@424 PS5, Line 424: MAC_PT_RLCMAC_NO_OPT (MAC_PT_RLCMAC_NO_OPT, MAC_PT_RLCMAC_OPT) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623/5/pcu/PCU_Tests_RAW.ttcn File pcu/PCU_Tests_RAW.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623/5/pcu/PCU_Tests_RAW.ttcn@1619 PS5, Line 1619: MobileL3_CommonIE_Types No need to use this prefix as you're importing all from MobileL3_CommonIE_Types. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623/5/pcu/PCU_Tests_RAW.ttcn@1653 PS5, Line 1653: := cosmetic: space is missing https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623/5/pcu/PCU_Tests_RAW.ttcn@1661 PS5, Line 1661: len So we only compare the lengths? Can we compare the identities too? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia3ad503c243c9b3b162e204683fa4fa5447bbab3 Gerrit-Change-Number: 15623 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lyn...@fe80.eu> Gerrit-Assignee: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 10 Dec 2019 08:18:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
