fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623 )
Change subject: pcu: add TC_paging_cs_from_bts ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623/5/pcu/PCU_Tests_RAW.ttcn File pcu/PCU_Tests_RAW.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623/5/pcu/PCU_Tests_RAW.ttcn@1661 PS5, Line 1661: len > wE can compare them (and it's a good idea indeed) but it's not trivial > afaict, since it's not binary compatible. Yep, they must be of the same type. You can either: - make use of MobileIdentityV (from MobileL3_CommonIE_Types.ttcn) in record MobileIdentityLV_Paging (preferred), or - introduce enc_MobileIdentityV (we already have enc_MobileIdentityLV in L3_Templates.ttcn), and compare octetstrings. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15623 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ia3ad503c243c9b3b162e204683fa4fa5447bbab3 Gerrit-Change-Number: 15623 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Assignee: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Wed, 11 Dec 2019 04:43:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
