keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16204 )
Change subject: contrib/dgsm/ add example esme and dialplan ...................................................................... Patch Set 18: (4 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/16204/18/contrib/dgsm/esme_dgsm.py File contrib/dgsm/esme_dgsm.py: https://gerrit.osmocom.org/c/osmo-hlr/+/16204/18/contrib/dgsm/esme_dgsm.py@4 PS18, Line 4: Copyright 2019 sysmocom s.f.m.c GmbH <[email protected]> > This file is based on code from Rhizomatica, released under AGPL (see comment > below in the file). If it's possible legally, as the author of the file this was based on, i'd give explicit permission to apply any less restrictive license. https://gerrit.osmocom.org/c/osmo-hlr/+/16204/18/contrib/dgsm/esme_dgsm.py@42 PS18, Line 42: logging.info('PDU is not a DeliverSM. Is OsmoMSC configured properly?') You may log a lot of Alert Notifications (1 for each LUR) at log level info. These do not necessarily reflect improper configuration, although it is advisable to not bombard this blocking script with them https://gerrit.osmocom.org/c/osmo-hlr/+/16204/18/contrib/dgsm/esme_dgsm.py@48 PS18, Line 48: " example, dropping message.") OOoops. There is certainly something wrong in RCCN! There is some unfinished code in there that should not exec, and a python indentation error, but the intention was to only reject certain messages with IEI != SMPP_UDHIEIE_CONCATENATED, these were mostly provider tracking messages or other non-user initiated SMS Multipart SMS should be handled. Just pass the pdu through. there's no reason not to as the receiving ME will reassemble. I would delete lines 45-49 https://gerrit.osmocom.org/c/osmo-hlr/+/16204/18/contrib/dgsm/esme_dgsm.py@87 PS18, Line 87: registered_delivery=False, OK, this is a P.O.C. for testing, but why not respect the delivery report request anyway? The receiving osmo-msc should generate the delivery report which should come back through the same routing as this message. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I26e8dd8d9a08187fccb3e74ee91366bc24f6c608 Gerrit-Change-Number: 16204 Gerrit-PatchSet: 18 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: keith <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2020 16:04:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
