osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16204 )
Change subject: contrib/dgsm/ add example esme and dialplan ...................................................................... Patch Set 22: (4 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/16204/18/contrib/dgsm/esme_dgsm.py File contrib/dgsm/esme_dgsm.py: https://gerrit.osmocom.org/c/osmo-hlr/+/16204/18/contrib/dgsm/esme_dgsm.py@4 PS18, Line 4: Copyright 2019 sysmocom s.f.m.c GmbH <[email protected]> > If it's possible legally, as the author of the file this was based on, i'd > give explicit permission […] As discussed in IRC: changed to MIT. https://gerrit.osmocom.org/c/osmo-hlr/+/16204/18/contrib/dgsm/esme_dgsm.py@42 PS18, Line 42: logging.info('PDU is not a DeliverSM. Is OsmoMSC configured properly?') > You may log a lot of Alert Notifications (1 for each LUR) at log level info. > […] Message changed to "PDU is not a DeliverSM, ignoring" https://gerrit.osmocom.org/c/osmo-hlr/+/16204/18/contrib/dgsm/esme_dgsm.py@48 PS18, Line 48: " example, dropping message.") > OOoops. […] Sorry to hear that there's a bug in RCCN :\ Thanks, I've deleted the lines. https://gerrit.osmocom.org/c/osmo-hlr/+/16204/18/contrib/dgsm/esme_dgsm.py@87 PS18, Line 87: registered_delivery=False, > OK, this is a P.O.C. […] Fixed. -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16204 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I26e8dd8d9a08187fccb3e74ee91366bc24f6c608 Gerrit-Change-Number: 16204 Gerrit-PatchSet: 22 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: keith <[email protected]> Gerrit-Comment-Date: Fri, 10 Jan 2020 14:43:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: osmith <[email protected]> Gerrit-MessageType: comment
