neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16459 )
Change subject: 2/2: fixup: add osmo_gsup_peer_id with type enum and union ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/16459/3/include/osmocom/gsupclient/gsup_peer_id.h File include/osmocom/gsupclient/gsup_peer_id.h: https://gerrit.osmocom.org/c/osmo-hlr/+/16459/3/include/osmocom/gsupclient/gsup_peer_id.h@30 PS3, Line 30: struct osmo_ipa_name { > So it is added in previous commit, then in this one it's moved to a new > header while adding a new os […] for hysterical raisins. I kept this separate because I was unsure whether we would keep this, in the end we could squash the two commits... https://gerrit.osmocom.org/c/osmo-hlr/+/16459/3/include/osmocom/gsupclient/gsup_req.h File include/osmocom/gsupclient/gsup_req.h: https://gerrit.osmocom.org/c/osmo-hlr/+/16459/3/include/osmocom/gsupclient/gsup_req.h@29 PS3, Line 29: (req) ? osmo_gsup_peer_id_to_str(&(req)->source_name) : "NULL", \ > it shouldn't be called source_name anymore, but source_id. you're probably right. let's figure out what we have... "ipa-name" in the vty config, "vlr_number" in the hlr.sql, osmo_gsup_peer_id added here; total mixup. Would be nice if we had some sort of a plan for the future. a utopia to converge towards? -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16459 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: Ide9dcdca283ab989240cfc6e53e9211862a199c5 Gerrit-Change-Number: 16459 Gerrit-PatchSet: 3 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Thu, 09 Jan 2020 16:43:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
