neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/16262 )

Change subject: vty: show subscriber: show lu d,h,m,s ago, not just seconds
......................................................................


Patch Set 15:

(2 comments)

https://gerrit.osmocom.org/c/osmo-hlr/+/16262/14/src/hlr_vty_subscr.c
File src/hlr_vty_subscr.c:

https://gerrit.osmocom.org/c/osmo-hlr/+/16262/14/src/hlr_vty_subscr.c@62
PS14, Line 62: #define UNIT_AGO(UNITNAME, UNITVAL) \
> I'm pretty sure max already did something similar (libosmocore counters?) We 
> may have something we c […]
can't find anything, let me know if you can


https://gerrit.osmocom.org/c/osmo-hlr/+/16262/14/src/hlr_vty_subscr.c@67
PS14, Line 67:          UNIT_AGO("d", 60*60*24);
> Wrong indentation starting from here.
I don't see any wrong indentation?



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16262
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I0fe34e0f065160ef959b2b7b4dd040f3f2985f43
Gerrit-Change-Number: 16262
Gerrit-PatchSet: 15
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: pespin <[email protected]>
Gerrit-Comment-Date: Thu, 09 Jan 2020 18:11:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>
Gerrit-MessageType: comment

Reply via email to