laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/17095 )
Change subject: dtx: add decoding for AMR-DTX frames ...................................................................... Patch Set 10: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/libosmocore/+/17095/10/src/coding/gsm0503_amr_dtx.c File src/coding/gsm0503_amr_dtx.c: https://gerrit.osmocom.org/c/libosmocore/+/17095/10/src/coding/gsm0503_amr_dtx.c@228 PS10, Line 228: static inline bool detect_afs_sid_first(int *n_errors, int *n_bits_total, const ubit_t *ubits) I would argue you can remove all that explicit 'inline'. The functions are static anyway, and the compiler will figure out the inlining by itself. https://gerrit.osmocom.org/c/libosmocore/+/17095/10/src/coding/gsm0503_coding.c File src/coding/gsm0503_coding.c: https://gerrit.osmocom.org/c/libosmocore/+/17095/10/src/coding/gsm0503_coding.c@2203 PS10, Line 2203: if (*dtx == AFS_SID_UPDATE) style-wise, I would have used a switch (*dtx) here, but please don't change it now, just mentioning it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/17095 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2bbdb39ea20461ca08b2e6f1a33532cb55cd5195 Gerrit-Change-Number: 17095 Gerrit-PatchSet: 10 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 19 Mar 2020 09:05:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
