neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17381 )
Change subject: mobile: loopback voice frames ...................................................................... Patch Set 4: OK, back to my original opinion: the msgb_pull and msgb_push are very inexpensive operations, let's actually do always compose the mncc header regardless of whether it is going to be used in below conditions. So, to clarify, the loopback *is* conditional in this patch. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icd0b8d00c855db1a6ff5e35e10c8ff67b7ad5c83 Gerrit-Change-Number: 17381 Gerrit-PatchSet: 4 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 30 Mar 2020 16:53:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
