osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/17381 )
Change subject: mobile: loopback voice frames ...................................................................... Patch Set 6: -Code-Review (1 comment) https://gerrit.osmocom.org/c/osmocom-bb/+/17381/6/src/host/layer23/src/mobile/voice.c File src/host/layer23/src/mobile/voice.c: https://gerrit.osmocom.org/c/osmocom-bb/+/17381/6/src/host/layer23/src/mobile/voice.c@44 PS6, Line 44: GSM_TCHF_FRAME > I think this implicitly means FR. […] I recommend to make it FR-only in this patch, as making it work with EFR needs unrelated adjustments in the magic checking code (0xd vs 0xc), see: https://git.osmocom.org/osmocom-bb/commit/?h=osmith/virt-voice&id=7bee40eafb8896c6664e3407371de7e87665ba1a I'll create a proper version of that patch today, to add EFR support (instead of replacing FR -> EFR) on top of this patch currently in gerrit. -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/17381 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: Icd0b8d00c855db1a6ff5e35e10c8ff67b7ad5c83 Gerrit-Change-Number: 17381 Gerrit-PatchSet: 6 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 04 May 2020 08:45:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
