fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17221 )
Change subject: dtx: add detection of AMR DTX frames for osmo-bts-trx ...................................................................... Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/common/scheduler.c File src/common/scheduler.c: https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/common/scheduler.c@762 PS4, Line 762: l1sap->u.tch.is_sub = is_sub & 1; > since it's a bool ,simply assign. AFAIR, l1sap->u.tch.is_sub is a bit field: uint8_t is_sub:1; not a bool. -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5afe730fff2fa3199a5913b0de4f5c7b23a39f31 Gerrit-Change-Number: 17221 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Wed, 22 Apr 2020 12:34:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
