dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17221 )
Change subject: dtx: add detection of AMR DTX frames for osmo-bts-trx ...................................................................... Patch Set 5: (4 comments) > Patch Set 4: > > (1 comment) I have skipped the transition of is_sub to bool. Using an uint_t was intentional to match the original definition uint8_t is_sub:1. Please let me know if I should change it anyway, but I wanted to be sure that you know the reasons first. https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/osmo-bts-trx/scheduler_trx.c File src/osmo-bts-trx/scheduler_trx.c: https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/osmo-bts-trx/scheduler_trx.c@1210 PS4, Line 1210: * voce frame after the AFS_ONSET frame actually is the first > typo: voce -> voice Done https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/osmo-bts-trx/scheduler_trx.c@1211 PS4, Line 1211: * real voice frame that is will also result into an RTP frame. */ > "that is will also" I don't understand this, please fix. Done https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/osmo-bts-trx/scheduler_trx.c@1250 PS4, Line 1250: if (chan_state->amr_last_dtx == AMR_OTHER) > either […] Done https://gerrit.osmocom.org/c/osmo-bts/+/17221/4/src/osmo-bts-trx/scheduler_trx.c@1497 PS4, Line 1497: if (chan_state->amr_last_dtx == AMR_OTHER) > either […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/17221 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I5afe730fff2fa3199a5913b0de4f5c7b23a39f31 Gerrit-Change-Number: 17221 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Wed, 22 Apr 2020 15:23:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
