neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/17580 )
Change subject: manual: link to new common cs7-config.adoc, remove some dup of that ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/17580/2/doc/manuals/chapters/running.adoc File doc/manuals/chapters/running.adoc: https://gerrit.osmocom.org/c/osmo-msc/+/17580/2/doc/manuals/chapters/running.adoc@104 PS2, Line 104: sctp-role client > Please explicitly state the AS and ASP. […] And then, would they also be surprised not to see a routing-key configured? For typical osmocom usage, adding a routing-key complicates things. So I had it in the example, only commented out. That precisely is where the discussion started: I should remove that comment. See here: https://gerrit.osmocom.org/c/osmo-bsc/+/17503/2/doc/manuals/chapters/running.adoc#91 So then I went with the minimal example that works with osmocom, omitting any automatically added config. The final and merged patch set of above link resembles exactly this patch here. I think that is still the best way. This is supposed to be a minimal hint to get a configuration working quickly. The full explanation is in <<cs7_config>>. But I am glad to adhere to finally get this merged, if we can't merge it as-is. To be clear, I should add the AS and ASP, but not the routing-key? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/17580 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ie88dd2c7f7318a31ae04fbd6930346d92141fde5 Gerrit-Change-Number: 17580 Gerrit-PatchSet: 2 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Tue, 19 May 2020 20:53:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
