fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/18347 )
Change subject: add osmo-bsc -X: dump VTY ref XML to stdout ...................................................................... Patch Set 4: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/18347/4/src/osmo-bsc/osmo_bsc_main.c File src/osmo-bsc/osmo_bsc_main.c: https://gerrit.osmocom.org/c/osmo-bsc/+/18347/4/src/osmo-bsc/osmo_bsc_main.c@113 PS4, Line 113: -X Are you sure '-X' is not used anywhere else in osmo-* projects? Maybe introducing only the long option ('--vty-ref-xml') would be enough? -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18347 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I316efedb2c1652791434ecf14a1e261367cd2fb7 Gerrit-Change-Number: 18347 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Thu, 21 May 2020 17:28:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment