fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bsc/+/18374 )

Change subject: manuals: generate vty reference xml at build time
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/c/osmo-bsc/+/18374/2/doc/manuals/Makefile.am
File doc/manuals/Makefile.am:

https://gerrit.osmocom.org/c/osmo-bsc/+/18374/2/doc/manuals/Makefile.am@24
PS2, Line 24: $(top_builddir)/src/osmo-bsc/osmo-bsc
> Are you sure that makes sense when building with -j8?

I think it's ok since we depend on the target binary here.



--
To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/18374
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I5dc872149154e1a949bb6a2b9bbc1461e0fc51f6
Gerrit-Change-Number: 18374
Gerrit-PatchSet: 2
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 21 May 2020 17:35:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to