fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-pcu/+/18387 )

Change subject: BTS::parse_rach_ind(): properly handle EGPRS Packet Channel 
Request
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/c/osmo-pcu/+/18387/2/src/bts.cpp
File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/18387/2/src/bts.cpp@719
PS2, Line 719:          /* TODO: IIUC, signalling needs only one block */
> Then please at least log something here.
That's my question, what is this magic 'something' I should log? :P
I'll update a new change assuming single block here as it seems logical to me.



--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/18387
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia15761c33c8048d35c7f7bc93dbea781dd0894b7
Gerrit-Change-Number: 18387
Gerrit-PatchSet: 3
Gerrit-Owner: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <axilira...@gmail.com>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Thu, 21 May 2020 19:03:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Comment-In-Reply-To: fixeria <axilira...@gmail.com>
Gerrit-MessageType: comment

Reply via email to