laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/17848 )
Change subject: commands.py: fix read_binary for lengths > 256 ...................................................................... Patch Set 8: > I got a couple of SIMs with the PLMN lists with 300 bytes. I am happy to add > the test if needed, is just that I was told this is tested with real HW only? At sysmocom, we can create a SIM card profile card with larger files for our test environment. It would just be good if we don't create a completely artificial test, but reproduce something that you actually saw on real SIM Cards. So if you can make it work on your side and send us some APDU logs, and/or even the related test - great. we then simply create a SIM card with the same-sized file and identical content here. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/17848 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie9c61caa1412606254b44a3a24f26ad44950e73a Gerrit-Change-Number: 17848 Gerrit-PatchSet: 8 Gerrit-Owner: [email protected] <[email protected]> Gerrit-Assignee: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: [email protected] <[email protected]> Gerrit-CC: dexter <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Wed, 03 Jun 2020 20:57:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
