herlesupreeth has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/17848 )
Change subject: commands.py: fix read_binary for lengths > 256
......................................................................
Patch Set 8:
> Patch Set 8:
>
> > I got a couple of SIMs with the PLMN lists with 300 bytes. I am happy to
> > add the test if needed, is just that I was told this is tested with real HW
> > only?
>
> At sysmocom, we can create a SIM card profile card with larger files for our
> test environment. It would just be good if we don't create a completely
> artificial test, but reproduce something that you actually saw on real SIM
> Cards. So if you can make it work on your side and send us some APDU logs,
> and/or even the related test - great. we then simply create a SIM card with
> the same-sized file and identical content here.
Just couple of tests/inputs from my side. I can verify the working of this
patch on a real commercial USIM from Vodafone DE.
Before the patch
~/pysim$ ./pySim-read.py -p 0
Using PC/SC reader interface
Reading ...
Autodetection failed
ICCID: 89xxxxxxx7603xxxx429
IMSI: 262xxxxxx87xxxx
GID1: ff
GID2: ff
SMSP:
fffffffffffffffffffffffffffffffffffffdffffffffffffffffffffffff0791947122723033ffffffffffffff
SPN: Not available
Display HPLMN: True
Display OPLMN: True
PLMNsel:
32f21012f41022f20132f45102f80102f44022f81082f62052f01006f22012f90132f03062f01002f61025f09925f00025f04004f43404f41104f40204f47204f45032f81052f51042f08002f25072f07703021622f05042f21012f60754f44054f43062f81025f55005f53056f51022f61072f62082f41042f45072f21032f11012f80972f81092f30433085024f72043f00204f40314f20206f33042f75042f62042f82014f92037f01052f72024f01015f53024f62014f32016f70192f71014f61092f43005f29182f35046f04072f42082f01036f92004f01026f510ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
PLMNwAcT: Can't read file -- list index out of range
OPLMNwAcT: Can't read file -- list index out of range
HPLMNAcT:
62f220c080 # MCC: 262 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
ffffff0000 # unused
ACC: 0100
.....
-----------------------------------------------------------------------------
After the patch
~/pysim$ ./pySim-read.py -p 0
Using PC/SC reader interface
Reading ...
Autodetection failed
ICCID: 89xxxxxxx7603xxxx429
IMSI: 262xxxxxx87xxxx
GID1: ff
GID2: ff
SMSP:
fffffffffffffffffffffffffffffffffffffdffffffffffffffffffffffff0791947122723033ffffffffffffff
SPN: Not available
Display HPLMN: True
Display OPLMN: True
PLMNsel:
32f21012f41022f20132f45102f80102f44022f81082f62052f01006f22012f90132f03062f01002f61025f09925f00025f04004f43404f41104f40204f47204f45032f81052f51042f08002f25072f07703021622f05042f21012f60754f44054f43062f81025f55005f53056f51022f61072f62082f41042f45072f21032f11012f80972f81092f30433085024f72043f00204f40314f20206f33042f75042f62042f82014f92037f01052f72024f01015f53024f62014f32016f70192f71014f61092f43005f29182f35046f04072f42082f01036f92004f01026f510ffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff
PLMNwAcT:
32f210c080 # MCC: 232 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
12f410c080 # MCC: 214 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
22f201c080 # MCC: 222 MNC: 010 AcT: UTRAN, E-UTRAN, GSM
32f451c080 # MCC: 234 MNC: 015 AcT: UTRAN, E-UTRAN, GSM
02f801c080 # MCC: 208 MNC: 010 AcT: UTRAN, E-UTRAN, GSM
02f440c080 # MCC: 204 MNC: 004 AcT: UTRAN, E-UTRAN, GSM
22f810c080 # MCC: 228 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
32f210c080 # MCC: 232 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
82f620c080 # MCC: 286 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
52f010c080 # MCC: 250 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
06f220c080 # MCC: 602 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
12f901c080 # MCC: 219 MNC: 010 AcT: UTRAN, E-UTRAN, GSM
32f030c080 # MCC: 230 MNC: 003 AcT: UTRAN, E-UTRAN, GSM
62f010c080 # MCC: 260 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
02f610c080 # MCC: 206 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
25f099c080 # MCC: 520 MNC: 099 AcT: UTRAN, E-UTRAN, GSM
25f000c080 # MCC: 520 MNC: 000 AcT: UTRAN, E-UTRAN, GSM
25f040c080 # MCC: 520 MNC: 004 AcT: UTRAN, E-UTRAN, GSM
04f434c080 # MCC: 404 MNC: 043 AcT: UTRAN, E-UTRAN, GSM
04f411c080 # MCC: 404 MNC: 011 AcT: UTRAN, E-UTRAN, GSM
04f402c080 # MCC: 404 MNC: 020 AcT: UTRAN, E-UTRAN, GSM
04f472c080 # MCC: 404 MNC: 027 AcT: UTRAN, E-UTRAN, GSM
04f450c080 # MCC: 404 MNC: 005 AcT: UTRAN, E-UTRAN, GSM
32f810c080 # MCC: 238 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
52f510c080 # MCC: 255 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
42f080c080 # MCC: 240 MNC: 008 AcT: UTRAN, E-UTRAN, GSM
02f250c080 # MCC: 202 MNC: 005 AcT: UTRAN, E-UTRAN, GSM
72f077c080 # MCC: 270 MNC: 077 AcT: UTRAN, E-UTRAN, GSM
030216c080 # MCC: 302 MNC: 610 AcT: UTRAN, E-UTRAN, GSM
22f050c080 # MCC: 220 MNC: 005 AcT: UTRAN, E-UTRAN, GSM
42f210c080 # MCC: 242 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
12f607c080 # MCC: 216 MNC: 070 AcT: UTRAN, E-UTRAN, GSM
54f440c080 # MCC: 454 MNC: 004 AcT: UTRAN, E-UTRAN, GSM
54f430c080 # MCC: 454 MNC: 003 AcT: UTRAN, E-UTRAN, GSM
62f810c080 # MCC: 268 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
25f550c080 # MCC: 525 MNC: 005 AcT: UTRAN, E-UTRAN, GSM
05f530c080 # MCC: 505 MNC: 003 AcT: UTRAN, E-UTRAN, GSM
56f510c080 # MCC: 655 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
22f610c080 # MCC: 226 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
72f620c080 # MCC: 276 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
82f410c080 # MCC: 284 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
42f450c080 # MCC: 244 MNC: 005 AcT: UTRAN, E-UTRAN, GSM
72f210c080 # MCC: 272 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
32f110c080 # MCC: 231 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
12f809c080 # MCC: 218 MNC: 090 AcT: UTRAN, E-UTRAN, GSM
72f810c080 # MCC: 278 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
92f304c080 # MCC: 293 MNC: 040 AcT: UTRAN, E-UTRAN, GSM
330850c080 # MCC: 338 MNC: 050 AcT: UTRAN, E-UTRAN, GSM
24f720c080 # MCC: 427 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
43f002c080 # MCC: 340 MNC: 020 AcT: UTRAN, E-UTRAN, GSM
04f403c080 # MCC: 404 MNC: 030 AcT: UTRAN, E-UTRAN, GSM
14f202c080 # MCC: 412 MNC: 020 AcT: UTRAN, E-UTRAN, GSM
06f330c080 # MCC: 603 MNC: 003 AcT: UTRAN, E-UTRAN, GSM
42f750c080 # MCC: 247 MNC: 005 AcT: UTRAN, E-UTRAN, GSM
42f620c080 # MCC: 246 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
42f820c080 # MCC: 248 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
14f920c080 # MCC: 419 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
37f010c080 # MCC: 730 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
52f720c080 # MCC: 257 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
24f010c080 # MCC: 420 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
15f530c080 # MCC: 515 MNC: 003 AcT: UTRAN, E-UTRAN, GSM
24f620c080 # MCC: 426 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
14f320c080 # MCC: 413 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
16f701c080 # MCC: 617 MNC: 010 AcT: UTRAN, E-UTRAN, GSM
92f710c080 # MCC: 297 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
14f610c080 # MCC: 416 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
92f430c080 # MCC: 294 MNC: 003 AcT: UTRAN, E-UTRAN, GSM
05f291c080 # MCC: 502 MNC: 019 AcT: UTRAN, E-UTRAN, GSM
82f350c080 # MCC: 283 MNC: 005 AcT: UTRAN, E-UTRAN, GSM
46f040c080 # MCC: 640 MNC: 004 AcT: UTRAN, E-UTRAN, GSM
72f420c080 # MCC: 274 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
82f010c080 # MCC: 280 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
36f920c080 # MCC: 639 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
04f010c080 # MCC: 400 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
26f510c080 # MCC: 625 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
OPLMNwAcT:
32f210c080 # MCC: 232 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
12f410c080 # MCC: 214 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
22f201c080 # MCC: 222 MNC: 010 AcT: UTRAN, E-UTRAN, GSM
32f451c080 # MCC: 234 MNC: 015 AcT: UTRAN, E-UTRAN, GSM
02f801c080 # MCC: 208 MNC: 010 AcT: UTRAN, E-UTRAN, GSM
02f440c080 # MCC: 204 MNC: 004 AcT: UTRAN, E-UTRAN, GSM
22f810c080 # MCC: 228 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
32f210c080 # MCC: 232 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
82f620c080 # MCC: 286 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
52f010c080 # MCC: 250 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
06f220c080 # MCC: 602 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
12f901c080 # MCC: 219 MNC: 010 AcT: UTRAN, E-UTRAN, GSM
32f030c080 # MCC: 230 MNC: 003 AcT: UTRAN, E-UTRAN, GSM
62f010c080 # MCC: 260 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
02f610c080 # MCC: 206 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
25f099c080 # MCC: 520 MNC: 099 AcT: UTRAN, E-UTRAN, GSM
25f000c080 # MCC: 520 MNC: 000 AcT: UTRAN, E-UTRAN, GSM
25f040c080 # MCC: 520 MNC: 004 AcT: UTRAN, E-UTRAN, GSM
04f434c080 # MCC: 404 MNC: 043 AcT: UTRAN, E-UTRAN, GSM
04f411c080 # MCC: 404 MNC: 011 AcT: UTRAN, E-UTRAN, GSM
04f402c080 # MCC: 404 MNC: 020 AcT: UTRAN, E-UTRAN, GSM
04f472c080 # MCC: 404 MNC: 027 AcT: UTRAN, E-UTRAN, GSM
04f450c080 # MCC: 404 MNC: 005 AcT: UTRAN, E-UTRAN, GSM
32f810c080 # MCC: 238 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
52f510c080 # MCC: 255 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
42f080c080 # MCC: 240 MNC: 008 AcT: UTRAN, E-UTRAN, GSM
02f250c080 # MCC: 202 MNC: 005 AcT: UTRAN, E-UTRAN, GSM
72f077c080 # MCC: 270 MNC: 077 AcT: UTRAN, E-UTRAN, GSM
030216c080 # MCC: 302 MNC: 610 AcT: UTRAN, E-UTRAN, GSM
22f050c080 # MCC: 220 MNC: 005 AcT: UTRAN, E-UTRAN, GSM
42f210c080 # MCC: 242 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
12f607c080 # MCC: 216 MNC: 070 AcT: UTRAN, E-UTRAN, GSM
54f440c080 # MCC: 454 MNC: 004 AcT: UTRAN, E-UTRAN, GSM
54f430c080 # MCC: 454 MNC: 003 AcT: UTRAN, E-UTRAN, GSM
62f810c080 # MCC: 268 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
25f550c080 # MCC: 525 MNC: 005 AcT: UTRAN, E-UTRAN, GSM
05f530c080 # MCC: 505 MNC: 003 AcT: UTRAN, E-UTRAN, GSM
56f510c080 # MCC: 655 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
22f610c080 # MCC: 226 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
72f620c080 # MCC: 276 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
82f410c080 # MCC: 284 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
42f450c080 # MCC: 244 MNC: 005 AcT: UTRAN, E-UTRAN, GSM
72f210c080 # MCC: 272 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
32f110c080 # MCC: 231 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
12f809c080 # MCC: 218 MNC: 090 AcT: UTRAN, E-UTRAN, GSM
72f810c080 # MCC: 278 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
92f304c080 # MCC: 293 MNC: 040 AcT: UTRAN, E-UTRAN, GSM
330850c080 # MCC: 338 MNC: 050 AcT: UTRAN, E-UTRAN, GSM
24f720c080 # MCC: 427 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
43f002c080 # MCC: 340 MNC: 020 AcT: UTRAN, E-UTRAN, GSM
04f403c080 # MCC: 404 MNC: 030 AcT: UTRAN, E-UTRAN, GSM
14f202c080 # MCC: 412 MNC: 020 AcT: UTRAN, E-UTRAN, GSM
06f330c080 # MCC: 603 MNC: 003 AcT: UTRAN, E-UTRAN, GSM
42f750c080 # MCC: 247 MNC: 005 AcT: UTRAN, E-UTRAN, GSM
42f620c080 # MCC: 246 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
42f820c080 # MCC: 248 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
14f920c080 # MCC: 419 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
37f010c080 # MCC: 730 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
52f720c080 # MCC: 257 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
24f010c080 # MCC: 420 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
15f530c080 # MCC: 515 MNC: 003 AcT: UTRAN, E-UTRAN, GSM
24f620c080 # MCC: 426 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
14f320c080 # MCC: 413 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
16f701c080 # MCC: 617 MNC: 010 AcT: UTRAN, E-UTRAN, GSM
92f710c080 # MCC: 297 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
14f610c080 # MCC: 416 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
92f430c080 # MCC: 294 MNC: 003 AcT: UTRAN, E-UTRAN, GSM
05f291c080 # MCC: 502 MNC: 019 AcT: UTRAN, E-UTRAN, GSM
82f350c080 # MCC: 283 MNC: 005 AcT: UTRAN, E-UTRAN, GSM
46f040c080 # MCC: 640 MNC: 004 AcT: UTRAN, E-UTRAN, GSM
72f420c080 # MCC: 274 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
82f010c080 # MCC: 280 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
36f920c080 # MCC: 639 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
04f010c080 # MCC: 400 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
26f510c080 # MCC: 625 MNC: 001 AcT: UTRAN, E-UTRAN, GSM
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
ffffff0000 # unused
HPLMNAcT:
62f220c080 # MCC: 262 MNC: 002 AcT: UTRAN, E-UTRAN, GSM
ffffff0000 # unused
ACC: 0100
......
--
To view, visit https://gerrit.osmocom.org/c/pysim/+/17848
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ie9c61caa1412606254b44a3a24f26ad44950e73a
Gerrit-Change-Number: 17848
Gerrit-PatchSet: 8
Gerrit-Owner: [email protected] <[email protected]>
Gerrit-Assignee: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: [email protected] <[email protected]>
Gerrit-CC: dexter <[email protected]>
Gerrit-CC: herlesupreeth <[email protected]>
Gerrit-CC: laforge <[email protected]>
Gerrit-Comment-Date: Thu, 04 Jun 2020 04:37:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
