pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18644 )
Change subject: osmo-mgw: refactor endpoint and trunk handling ...................................................................... Patch Set 7: Code-Review+1 (2 comments) https://gerrit.osmocom.org/c/osmo-mgw/+/18644/7/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/18644/7/src/libosmo-mgcp/mgcp_endp.c@115 PS7, Line 115: default: As a general note, it's nowadays also good practice to not define default in switch(enum), because compilers catch not-handled cases and provides a warning/error, so it's useful when adding new types, the compiler will tell you everywhere where you need to update the code. https://gerrit.osmocom.org/c/osmo-mgw/+/18644/7/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/c/osmo-mgw/+/18644/7/src/libosmo-mgcp/mgcp_vty.c@300 PS7, Line 300: This extra whitespace should be removed. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia8cf4d6caf05a4e13f1f507dc68cbabb7e6239aa Gerrit-Change-Number: 18644 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Fri, 12 Jun 2020 17:10:28 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
