neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/18644 )
Change subject: osmo-mgw: refactor endpoint and trunk handling ...................................................................... Patch Set 7: (1 comment) https://gerrit.osmocom.org/c/osmo-mgw/+/18644/7/src/libosmo-mgcp/mgcp_endp.c File src/libosmo-mgcp/mgcp_endp.c: https://gerrit.osmocom.org/c/osmo-mgw/+/18644/7/src/libosmo-mgcp/mgcp_endp.c@115 PS7, Line 115: default: > As a general note, it's nowadays also good practice to not define default in > switch(enum), because c […] I gave review to the contrary... Coverity also warns about missing switch cases, introducing 'default:' that abort or handle errors is needed to silence those complaints. The compiler argument is a good one. After considering, I think it's still most important to not let a program continue to run after passing a switch with a missing case. Maybe the compiler is configured to ignore those warnings? Or I fail to read them? In any case I think we should take the discussion out of this patch so that we don't make dexter work in circles. So I'd say with or without default is both good enough for now. ok? -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/18644 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Ia8cf4d6caf05a4e13f1f507dc68cbabb7e6239aa Gerrit-Change-Number: 18644 Gerrit-PatchSet: 7 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Sat, 13 Jun 2020 11:01:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
