pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/18721 )
Change subject: UHDDevice: Implement getNominalTxPower() based on TxFrequency ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-trx/+/18721/2/Transceiver52M/device/uhd/UHDDevice.cpp File Transceiver52M/device/uhd/UHDDevice.cpp: https://gerrit.osmocom.org/c/osmo-trx/+/18721/2/Transceiver52M/device/uhd/UHDDevice.cpp@1029 PS2, Line 1029: if (band != 0 && req_band != band) { > Hi Pau, […] That's done in order to avoid misconfigurations of different TRX on different bands (which make no sense afaiu and means broken config), and as Eric explains we need a specific band to provide correct power. The problem you face looks more like we don't reset band to 0 when stopping() the device. Probably adding a bool set_after_stop = false and ten it set to true when setTxFreq() is called, and only do the check if set_after_stop==true, which then only checks for all trx but not fo first one. Please open a ticket. -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/18721 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: If7ef5bf95ffe4afe5864c0f051853aa38b9639eb Gerrit-Change-Number: 18721 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Hoernchen <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Reviewer: roh <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-Comment-Date: Sat, 27 Jun 2020 14:08:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
