neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19062 )
Change subject: bsc: add first test to verify System Information on RSL startup ...................................................................... Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19062/6/bsc/BSC_Tests.ttcn File bsc/BSC_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19062/6/bsc/BSC_Tests.ttcn@439 PS6, Line 439: }; > Did you think about moving this to a separate helper file? It's quite a lot > of lines and BSC_Tests. […] no, didn't consider it. it's big but does it matter? I'd be fine if someone else wants to move to a separate file later ... ? I can't be bothered tbh. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/19062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I6a8ef404087efee491390dc1d2452ac323f145f0 Gerrit-Change-Number: 19062 Gerrit-PatchSet: 6 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 06 Jul 2020 17:06:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
