neels has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hlr/+/19052 )

Change subject: manual: describe subscriber import by SQL
......................................................................


Patch Set 1:

(1 comment)

> Patch Set 1:
>
> (2 comments)

https://gerrit.osmocom.org/c/osmo-hlr/+/19052/1/doc/manuals/chapters/subscribers.adoc
 
File doc/manuals/chapters/subscribers.adoc:

https://gerrit.osmocom.org/c/osmo-hlr/+/19052/1/doc/manuals/chapters/subscribers.adoc@160
PS1, Line 160: id
> So I guess you can simply omit this field, and sqlite will pick a unique 
> value for you?
but below commands need to cross reference to the subscriber id.
another consideration is that the import must not create duplicates (I think 
it's safe from the unique constraint on MSISDN and IMSI).
anyway, there might be some SQL magic that gets the last added subscriber id 
and allows using that, but i'm not aware. maybe you can add such technique? (in 
another patch?)



--
To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/19052
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Change-Id: I3246e6d5364215a71c33b5aca876deab7b6cfd70
Gerrit-Change-Number: 19052
Gerrit-PatchSet: 1
Gerrit-Owner: neels <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <[email protected]>
Gerrit-Reviewer: dexter <[email protected]>
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: neels <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Comment-Date: Sat, 11 Jul 2020 01:59:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <[email protected]>
Gerrit-MessageType: comment

Reply via email to