pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19415 )
Change subject: socket: add osmo_sockaddr_cmp() ...................................................................... Patch Set 11: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/19415/11/src/socket.c@1568 PS11, Line 1568: int osmo_sockaddr_cmp(struct osmo_sockaddr *a, struct osmo_sockaddr *b) As usual, I see no point in checking and returning stuff for NULL pointers. What's the point comparing a sockaddr with NULL? Are we comparing apples and pears here? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19415 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I2d12ebae2710ffd17cf071e6ada0804e73f87dd6 Gerrit-Change-Number: 19415 Gerrit-PatchSet: 11 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2020 11:17:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
