pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19147 )
Change subject: socket: fix osmo_sock_get_ip_and_port for IPv6 ...................................................................... Patch Set 12: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19147/12//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/19147/12//COMMIT_MSG@9 PS12, Line 9: The struct sockaddr is too small for IPv6. IPv6 has a 16 byte address, while Here: current code (as you rebased) uses sockaddr_storage and not sockaddr, so this paragraph doesn't apply. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19147 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I4e69d814367168c05f0da161ec9b705db36ad096 Gerrit-Change-Number: 19147 Gerrit-PatchSet: 12 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Thu, 27 Aug 2020 12:26:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
