lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19143 )
Change subject: socket: introduce osmo_sock_init_osa & osmo_sock_init_osa_ofd ...................................................................... Patch Set 18: (8 comments) https://gerrit.osmocom.org/c/libosmocore/+/19143/13/include/osmocom/core/socket.h File include/osmocom/core/socket.h: https://gerrit.osmocom.org/c/libosmocore/+/19143/13/include/osmocom/core/socket.h@61 PS13, Line 61: int osmo_sock_init3(uint16_t type, uint8_t proto, > I agree on that Done https://gerrit.osmocom.org/c/libosmocore/+/19143/13/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/19143/13/src/socket.c@454 PS13, Line 454: osmo_strlcpy(dest.ip, "Invalid IP", 11) > I know the macro is used only here in a limited code base, but doing this > kind of macro safely would […] Done https://gerrit.osmocom.org/c/libosmocore/+/19143/13/src/socket.c@465 PS13, Line 465: * This function creates a new socket of the designated \a family, \a > No "family" parameter here. Done https://gerrit.osmocom.org/c/libosmocore/+/19143/13/src/socket.c@496 PS13, Line 496: if (flags & OSMO_SOCK_F_BIND && !local) { > maybe it's just my own uncertainty about operator precedence, but more braces > would be nice Done https://gerrit.osmocom.org/c/libosmocore/+/19143/13/src/socket.c@500 PS13, Line 500: > (ws: two blank lines) Done https://gerrit.osmocom.org/c/libosmocore/+/19143/13/src/socket.c@502 PS13, Line 502: if (flags & OSMO_SOCK_F_CONNECT && !remote) { > more braces would be nice Done https://gerrit.osmocom.org/c/libosmocore/+/19143/13/src/socket.c@508 PS13, Line 508: flags & OSMO_SOCK_F_CONNECT && > more braces would be nice Done https://gerrit.osmocom.org/c/libosmocore/+/19143/13/src/socket.c@525 PS13, Line 525: if (proto != IPPROTO_UDP || flags & OSMO_SOCK_F_UDP_REUSEADDR) { > more braces would be nice Done -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1eece543e3241ef0e095eb63bb831f7c15a16794 Gerrit-Change-Number: 19143 Gerrit-PatchSet: 18 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Comment-Date: Wed, 02 Sep 2020 16:27:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: neels <[email protected]> Gerrit-MessageType: comment
