lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/19143 )
Change subject: socket: introduce osmo_sock_init_osa & osmo_sock_init_osa_ofd ...................................................................... Patch Set 20: (1 comment) https://gerrit.osmocom.org/c/libosmocore/+/19143/20/src/socket.c File src/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/19143/20/src/socket.c@1019 PS20, Line 1019: return osmo_fd_init_ofd(ofd, osmo_sock_init_osa(type, proto, local, remote, flags)); > I think I already commented on this: First check for return of > osmo_sock_init_osa(), and if it fails […] we're doing it in every _ofd() function and the _ofd function checks the returncode early. If this is here a problem, let's do another commit fixing it for all _ofd function. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/19143 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I1eece543e3241ef0e095eb63bb831f7c15a16794 Gerrit-Change-Number: 19143 Gerrit-PatchSet: 20 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Assignee: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Comment-Date: Sat, 05 Sep 2020 15:47:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
