laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/20197 )
Change subject: ipaccess.h: Add more enum values and 'official' names
......................................................................
ipaccess.h: Add more enum values and 'official' names
Originally we only learned about the protocol from looking at hexdumps
without any specification or the like.
Due to a GPL request to ip.acecss, we actually do have an 'official'
resource: The packet-ipa.c from their wireshark-1.0.6ipa27.tar.gz
Let's use its contents to complete our definitions here.
Change-Id: Ic1f2b32c72d162f31b422293d2a361d528443f01
---
M include/osmocom/gsm/protocol/ipaccess.h
1 file changed, 23 insertions(+), 14 deletions(-)
Approvals:
Jenkins Builder: Verified
lynxis lazus: Looks good to me, approved
fixeria: Looks good to me, approved
diff --git a/include/osmocom/gsm/protocol/ipaccess.h
b/include/osmocom/gsm/protocol/ipaccess.h
index 80413d1..4f1d0b1 100644
--- a/include/osmocom/gsm/protocol/ipaccess.h
+++ b/include/osmocom/gsm/protocol/ipaccess.h
@@ -42,26 +42,35 @@
};
enum ipaccess_msgtype {
- IPAC_MSGT_PING = 0x00,
- IPAC_MSGT_PONG = 0x01,
- IPAC_MSGT_ID_GET = 0x04,
- IPAC_MSGT_ID_RESP = 0x05,
- IPAC_MSGT_ID_ACK = 0x06,
+ IPAC_MSGT_PING = 0x00, /* Heartbeet */
+ IPAC_MSGT_PONG = 0x01, /* Heartbeat Ack */
+ IPAC_MSGT_ID_GET = 0x04, /* Identity Request */
+ IPAC_MSGT_ID_RESP = 0x05, /* Identity */
+ IPAC_MSGT_ID_ACK = 0x06, /* Identity Ack */
+ IPAC_MSGT_ID_NACK = 0x07, /* Identity Nack */
+ IPAC_MSGT_PROXY = 0x08, /* Proxy */
+ IPAC_MSGT_PROXY_ACK = 0x09, /* Proxy Ack */
+ IPAC_MSGT_PROXY_NACK = 0x0a, /* Proxy Nack */
+ IPAC_MSGT_SSL_INFO = 0x0b, /* SSL Info */
/* OpenBSC extension */
IPAC_MSGT_SCCP_OLD = 0xff,
};
enum ipaccess_id_tags {
- IPAC_IDTAG_SERNR = 0x00,
- IPAC_IDTAG_UNITNAME = 0x01,
- IPAC_IDTAG_LOCATION1 = 0x02,
- IPAC_IDTAG_LOCATION2 = 0x03,
- IPAC_IDTAG_EQUIPVERS = 0x04,
- IPAC_IDTAG_SWVERSION = 0x05,
- IPAC_IDTAG_IPADDR = 0x06,
- IPAC_IDTAG_MACADDR = 0x07,
- IPAC_IDTAG_UNIT = 0x08,
+ IPAC_IDTAG_SERNR = 0x00, /* Unit Serial Number */
+ IPAC_IDTAG_UNITNAME = 0x01, /* Unit Name */
+ IPAC_IDTAG_LOCATION1 = 0x02, /* Unit Location */
+ IPAC_IDTAG_LOCATION2 = 0x03, /* Unit Type */
+ IPAC_IDTAG_EQUIPVERS = 0x04, /* Hardware Version */
+ IPAC_IDTAG_SWVERSION = 0x05, /* Software Version */
+ IPAC_IDTAG_IPADDR = 0x06, /* IP Address */
+ IPAC_IDTAG_MACADDR = 0x07, /* Ethernet Address */
+ IPAC_IDTAG_UNIT = 0x08, /* Unit ID */
+ IPAC_IDTAG_USERNAME = 0x09, /* User Name */
+ IPAC_IDTAG_PASSWORD = 0x0a, /* Password */
+ IPAC_IDTAG_ACCESS_CLASS = 0x0b, /* Access Class */
+ IPAC_IDTG_APP_PROTO_VER = 0x0c, /* Application Protocol Version
*/
};
/*
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/20197
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: Ic1f2b32c72d162f31b422293d2a361d528443f01
Gerrit-Change-Number: 20197
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <[email protected]>
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: lynxis lazus <[email protected]>
Gerrit-MessageType: merged
